Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(FileList): Show correct avatar for federated share owner #47441

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[stable28] fix(FileList): Show correct avatar for federated share owner #47441

merged 2 commits into from
Sep 19, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Aug 22, 2024 •
edited
Loading

Screenshot

Screenshot from 2024-09-18 16-54-57

Resolves : #44287

@nfebe nfebe added 2. developing Work in progress federated labels Aug 22, 2024
@Pytal

This comment was marked as resolved.

Sign in to view
@nfebe

This comment was marked as resolved.

Sign in to view
@susnux

This comment was marked as resolved.

Sign in to view
@nfebe

This comment was marked as resolved.

Sign in to view
@nfebe nfebe force-pushed the 44287-fix-avatar-fed-share-receiver branch 3 times, most recently from a1ba0cf to e531957 Compare August 26, 2024 10:56
@nfebe nfebe force-pushed the 44287-fix-avatar-fed-share-receiver branch from e531957 to b40e85c Compare September 18, 2024 11:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 18, 2024
View reviewed changes
apps/dav/lib/Connector/Sabre/FilesPlugin.php Fixed Show fixed Hide fixed
lib/public/IUser.php Fixed Show fixed Hide fixed
@skjnldsv

This comment was marked as resolved.

Sign in to view
@backportbot backportbot bot mentioned this pull request Sep 18, 2024
Closed
2 tasks
@nfebe nfebe force-pushed the 44287-fix-avatar-fed-share-receiver branch from b40e85c to 99b6b92 Compare September 18, 2024 12:53
@nfebe nfebe force-pushed the 44287-fix-avatar-fed-share-receiver branch 5 times, most recently from b531d7b to 30aaefd Compare September 18, 2024 15:57
@nfebe nfebe marked this pull request as ready for review September 18, 2024 15:57
@nfebe nfebe changed the title WIP : 44287 fix avatar fed share receiver 44287 fix avatar fed share receiver Sep 18, 2024
@nfebe nfebe changed the title 44287 fix avatar fed share receiver fix(FileList): Show correct avatar for federated share owner Sep 18, 2024
@nfebe nfebe added 3. to review Waiting for reviews 28-feedback and removed 2. developing Work in progress labels Sep 18, 2024
@nfebe nfebe added this to the Nextcloud 28.0.11 milestone Sep 18, 2024
@nfebe nfebe requested a review from susnux September 18, 2024 16:00
@nfebe
Copy link
Contributor Author

nfebe commented Sep 18, 2024

/backport to stable29

@skjnldsv skjnldsv changed the title fix(FileList): Show correct avatar for federated share owner [stable28 fix(FileList): Show correct avatar for federated share owner Sep 19, 2024
skjnldsv
skjnldsv reviewed Sep 19, 2024
View reviewed changes
lib/private/User/User.php Outdated Show resolved Hide resolved
@nfebe nfebe force-pushed the 44287-fix-avatar-fed-share-receiver branch 2 times, most recently from 079bd1e to 6eda58f Compare September 19, 2024 10:39
@nfebe
Copy link
Contributor Author

nfebe commented Sep 19, 2024

/compile

@nfebe nfebe changed the title [stable28 fix(FileList): Show correct avatar for federated share owner [stable28] fix(FileList): Show correct avatar for federated share owner Sep 19, 2024
@nfebe nfebe enabled auto-merge September 19, 2024 13:55
nfebe and others added 2 commits September 19, 2024 16:18
@nfebe
fix(Federation): Show some icon for federated users on shares
2b40fb4 
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nextcloud-command @nfebe
chore(assets): Recompile assets
a31607f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe force-pushed the 44287-fix-avatar-fed-share-receiver branch from 52350a9 to a31607f Compare September 19, 2024 15:18
@nfebe nfebe merged commit 6d62ca8 into stable28 Sep 19, 2024
56 checks passed
@nfebe nfebe deleted the 44287-fix-avatar-fed-share-receiver branch September 19, 2024 20:47
@backportbot backportbot bot mentioned this pull request Sep 19, 2024
Merged
2 tasks
@nfebe nfebe mentioned this pull request Sep 20, 2024
Closed
8 tasks
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
Merged
2 tasks
@nextcloud nextcloud deleted a comment from github-actions bot Nov 7, 2024
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@artonge artonge Awaiting requested review from artonge

@susnux susnux Awaiting requested review from susnux

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Waiting for reviews 28-feedback feedback-requested
Projects
📁 Files team
Status: 🏗️ In progress
Milestone
Nextcloud 28.0.11
Development

Successfully merging this pull request may close these issues.
7 participants
@nfebe @Pytal @susnux @skjnldsv @icewind1991 @come-nc @nextcloud-command